This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
[UNR-2735] Correctly report errors when cloud deployment fails to launch #1772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
DeploymentLauncher returned 0 if it failed to launch a deployment. We also weren't printing out the error output from DeploymentLauncher if there was stuff there (e.g. if the project name is wrong which causes the deployment list command to fail).
Primary reviewers
@MatthewSandfordImprobable @mironec